refactor(backfill): Use of PBJ gRPC Client Helidon instead of Vanilla Helidon. #1499
+372
−402
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlfredoG87
force-pushed
the
pbj-grpc-client
branch
from
e353d99 to
36b0351
Compare
AlfredoG87
changed the title
AlfredoG87
added
Block Node
AlfredoG87
force-pushed
the
pbj-grpc-client
branch
from
2617e8f to
32b70f4
Compare
AlfredoG87
force-pushed
the
pbj-grpc-client
branch
from
df25622 to
ee2871f
Compare
AlfredoG87
force-pushed
the
pbj-grpc-client
branch
4 times, most recently
from
7acc99e to
d918b87
Compare
ata-nas
reviewed
Aug 18, 2025
block-node/backfill/src/main/java/org/hiero/block/node/backfill/client/BlockNodeClient.java
Outdated
Show resolved
Hide resolved
block-node/backfill/src/main/java/org/hiero/block/node/backfill/client/BlockNodeClient.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/org/hiero/block/node/backfill/client/BlockStreamSubscribeUnparsedClient.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/org/hiero/block/node/backfill/client/BlockStreamSubscribeUnparsedClient.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/org/hiero/block/node/backfill/client/BlockStreamSubscribeUnparsedClient.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/org/hiero/block/node/backfill/client/BlockStreamSubscribeUnparsedClient.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/org/hiero/block/node/backfill/client/BlockStreamSubscribeUnparsedClient.java
Outdated
Show resolved
Hide resolved
block-node/backfill/src/main/java/org/hiero/block/node/backfill/BackfillPlugin.java
Outdated
Show resolved
Hide resolved
block-node/backfill/src/main/java/org/hiero/block/node/backfill/BackfillPlugin.java
Outdated
Show resolved
Hide resolved
block-node/backfill/src/main/java/org/hiero/block/node/backfill/client/BlockNodeClient.java
Outdated
Show resolved
Hide resolved
AlfredoG87
force-pushed
the
pbj-grpc-client
branch
from
af29e2a to
fb04732
Compare
AlfredoG87
force-pushed
the
pbj-grpc-client
branch
from
fb04732 to
94135e5
Compare
block-node/backfill/src/test/java/org/hiero/block/node/backfill/BackfillPluginTest.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/org/hiero/block/node/backfill/client/BlockStreamSubscribeUnparsedClient.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/org/hiero/block/node/backfill/client/BlockStreamSubscribeUnparsedClient.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/org/hiero/block/node/backfill/client/BlockStreamSubscribeUnparsedClient.java
Outdated
Show resolved
Hide resolved
...l/src/main/java/org/hiero/block/node/backfill/client/BlockStreamSubscribeUnparsedClient.java
Outdated
Show resolved
Hide resolved
…d of Vanilla Helidon. On the case of BlockStreamSubscribe I also refactored the custom client to use PBJ but with Unparsed response Codec. Signed-off-by: Alfredo Gutierrez Grajeda <alfredo@hashgraph.com>
removing vestigial class that is no longer used Signed-off-by: Alfredo Gutierrez Grajeda <alfredo@hashgraph.com>
…g misleading log removing unneeded modules Signed-off-by: Alfredo Gutierrez Grajeda <alfredo@hashgraph.com>
…nd Autonomous at the same time, found out that the connection to initiate a batch request most happen synchronously, so On-Demand should only have to wait for the current batch to be fetched before starting. Signed-off-by: Alfredo Gutierrez Grajeda <alfredo@hashgraph.com>
Signed-off-by: Alfredo Gutierrez Grajeda <alfredo@hashgraph.com>
Signed-off-by: Alfredo Gutierrez Grajeda <alfredo@hashgraph.com>
AlfredoG87
force-pushed
the
pbj-grpc-client
branch
from
0d36fea to
3757c75
Compare
Signed-off-by: Alfredo Gutierrez Grajeda <alfredo@hashgraph.com>
jsync-swirlds
approved these changes
Aug 19, 2025
ata-nas
approved these changes
Aug 19, 2025
Codecov Report❌ Patch coverage is ❌ Your patch status has failed because the patch coverage (73.27%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. @@ Coverage Diff @@
## main #1499 +/- ##
============================================
+ Coverage 81.01% 81.15% +0.13%
Complexity 1110 1110
============================================
Files 123 122 -1
Lines 5121 5072 -49
Branches 535 529 -6
============================================
- Hits 4149 4116 -33
+ Misses 726 719 -7
+ Partials 246 237 -9
... and 1 file with indirect coverage changes 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer Notes
Refactored the BlockNodeClient to use PBJ gRPC Client Helidon, instead of Vanilla Helidon.
On the case of BlockStreamSubscribe I also refactored the custom client to use PBJ but with Unparsed response Codec.
Related Issue(s)
Fixes #1434
Fixes #1500
Fixes #1486